Fixed an error description of func, and deleted redundant codes #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaoyq
force-pushed
the
fix-a-err-description-of-func-and-del-invalid-code
branch
2 times, most recently
from
057bac9
to
01cf166
Compare
miaoyq
changed the title
|
[test] LGTM, holding to merge post-1.3. |
|
@miaoyq thanks for the PR! |
openshift-bot
added
the
needs-rebase
miaoyq
force-pushed
the
fix-a-err-description-of-func-and-del-invalid-code
branch
from
01cf166
to
ed14146
Compare
openshift-bot
removed
the
needs-rebase
|
@fabianofranz I have rebased the PR. Could you please trigger a test? Thanks! |
|
[test] |
miaoyq
force-pushed
the
fix-a-err-description-of-func-and-del-invalid-code
branch
from
ed14146
to
d021dcf
Compare
|
The test still failed, but it didn't seem to be caused by the PR. |
|
Flaked on #11094 |
|
Evaluated for origin test up to d021dcf |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9360/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9360/) (Image: devenv-rhel7_5085) |
|
Evaluated for origin merge up to d021dcf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if kcmdutil.GetFlagBool(cmd, "parameters") || outputFormat == "describe"can't be executed.The function will return in earlier if the condition is true.